Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simple tests for RobotModelController #2009

Merged
merged 6 commits into from
Feb 13, 2025
Merged

Add simple tests for RobotModelController #2009

merged 6 commits into from
Feb 13, 2025

Conversation

aeshub
Copy link
Contributor

@aeshub aeshub commented Feb 5, 2025 •
edited
Loading

Ready for review checklist:

  • A self-review has been performed
  • All commits run individually
  • Temporary changes have been removed, like console.log, TODO, etc.
  • The PR has been tested locally
  • A test have been written
    • This change doesn't need a new test
  • Relevant issues are linked
  • Remaining work is documented in issues
    • There is no remaining work from this PR that require new issues
  • The changes does not introduce dead code as unused imports, functions etc.

@aeshub aeshub added the improvement Improvement to existing functionality label Feb 5, 2025
@aeshub aeshub self-assigned this Feb 5, 2025
@aeshub aeshub force-pushed the testing branch 2 times, most recently from 97162bb to e865454 Compare February 12, 2025 13:25
andchiind
andchiind approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@andchiind andchiind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeshub
Add test for list all robot models
bb1816f
@aeshub
Add test for looking up robot model by type
c29521b
@aeshub
Add test for reading robot model by id
5818423
@aeshub
Remove the endpoint for deleting a robot model
aa7556d 
This endpoint is never used and it should not be possible to
make this destructive action. If deleting a RobotModel should
be considered it would require some care and thought to the
decision.
@aeshub
Add tests for updating of robot models
508591c
@aeshub
Add test for create robot model endpoint
ba93dbe
@aeshub aeshub merged commit bd97660 into equinor:main Feb 13, 2025
12 checks passed
@aeshub aeshub deleted the testing branch February 13, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andchiind andchiind andchiind approved these changes

Assignees

@aeshub aeshub

Labels
improvement Improvement to existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aeshub @andchiind